This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Few more possible regular expressions to check checkbox is checked #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her a checkbox is checked.
| @@ -381,6 +383,9 @@ public function assertCheckboxChecked($checkbox) | |||
| * Checks, that checkbox with specified in|name|label|value is unchecked. | |||
| * | |||
| * @Then /^the "(?P<checkbox>(?:[^"]|\\")*)" checkbox should not be checked$/ | |||
| * @Then /^I (?:|should )see the checkbox "(?P<checkbox>(?:[^"]|\\")*)" (?:is not checked|is unchecked)$/ | |||
There was a problem hiding this comment.
This does not look like an English sentence. you have 2 verbs
There was a problem hiding this comment.
Right. The we can remove "I should see .... " from the above regular expression and keep the rest.??
|
And the trait should be kept in sync with the class |
|
Could you please point it out at one example here? I am not able to figure out the trait. :) (Sundar is new here and is trying to learn new stuff on git as much as possible. Please excuse.) |
|
you have to update this file to keep the same step definitions |
… trait to be in sync with minkcontext.
everzet
added a commit
that referenced
this pull request
Mar 9, 2013
Few more possible regular expressions to check checkbox is checked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple of regular expressions that helps the user to check if a checkbox is checked or not on a page.
Committed here - de37a1a
Is it worth?